Re: [PATCH] test: make it possible to have multiple corpora

Subject: Re: [PATCH] test: make it possible to have multiple corpora

Date: Sun, 11 Sep 2016 15:37:03 -0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner


Jani Nikula <jani@nikula.org> writes:

>
> Even for the *one* message in the referenced patch, I don't know where I
> would put it as a message file. I worked around the issue by using a
> here document (which you objected to), but it's a general problem. If
> there's an issue someone sees, we can't just shove the message (or a set
> of messages) that reproduces the issue under corpus, because it would
> screw up all the other tests. There needs to be some other place. This
> seemed like a generic approach to the problem.
>
> I could also imagine a shell helper function to add a single message
> from somewhere under corpora to the db for testing. For some cases, it
> might be more readable than using add_message. (And for my case, it's
> impossible to use add_message because I need a broken message.)
>

OK, I didn't understand the combination of these two problems. In that
case, the change makes sense to me.

d

Thread: