Re: [PATCH] build: drop support for gmime-2.6

Subject: Re: [PATCH] build: drop support for gmime-2.6

Date: Wed, 01 May 2019 16:14:00 -0400

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Daniel Kahn Gillmor

On Wed 2019-05-01 07:46:43 -0300, David Bremner wrote:
> GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in
> notmuch for about 1.5 years.

I was just looking at this change myself.

As a gmime maintainer in debian, I'd love to see it happen, but i think
the right way to do that is to prune/reverse many of the versioned
translations in util/gmime-extra.h, so that we're using the "native"
gmime 3.0 API, rather than a mishmash of the 2.6 and 3.0 API.

And we should probably tear out all the #if (GMIME_MAJOR_VERSION < 3)
stanzas in the source as well.

    --dkg

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: [PATCH v2 01/15] build: drop support for gmime-2.6

Thread:

• David Bremner—[PATCH] build: drop support for gmime-2.6 [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Tomi Ollila—Re: [PATCH] build: drop support for gmime-2.6 [inbox, unread]
    • David Bremner—Re: [PATCH] build: drop support for gmime-2.6 [inbox, unread]
  • Daniel Kahn Gillmor—Re: [PATCH] build: drop support for gmime-2.6 [inbox, signed, unread]
    • David Bremner—Re: [PATCH] build: drop support for gmime-2.6 [inbox, unread]
      • Rollins, Jameson—Re: [PATCH] build: drop support for gmime-2.6 [inbox, unread]
        • David Bremner—Re: [PATCH] build: drop support for gmime-2.6 [inbox, unread]
          • Rollins, Jameson—Re: [PATCH] build: drop support for gmime-2.6 [inbox, unread]
  • Daniel Kahn Gillmor—Dropping GMime 2.6 compatibility layer [inbox, unread]
    • Daniel Kahn Gillmor—[PATCH 01/16] gmime-cleanup: drop unused gmime 2.6 content_type from _index_encrypted_mime_part [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: [PATCH 01/16] gmime-cleanup: drop unused gmime 2.6 content_type from _index_encrypted_mime_part [inbox, unread]
    • Daniel Kahn Gillmor—[PATCH 02/16] gmime-cleanup: remove GMime 2.6 variant codeblocks [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
    • Daniel Kahn Gillmor—[PATCH 03/16] gmime-cleanup: remove obsolete gpg_path configuration option and crypto contexts [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: [PATCH 03/16] gmime-cleanup: remove obsolete gpg_path configuration option and crypto contexts [inbox, unread]
        • Daniel Kahn Gillmor—Re: [PATCH 03/16] gmime-cleanup: remove obsolete gpg_path configuration option and crypto contexts [inbox, unread]
    • Daniel Kahn Gillmor—[PATCH 04/16] gmime-cleanup: always support session keys [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
    • Daniel Kahn Gillmor—[PATCH 05/16] gmime-cleanup: tests should only care about gmime 3 [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
    • Daniel Kahn Gillmor—[PATCH 06/16] gmime-cleanup: simplify T355-smime.sh [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
    • Daniel Kahn Gillmor—[PATCH 07/16] gmime-cleanup: drop g_mime_2_6_unref [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
    • Daniel Kahn Gillmor—[PATCH 08/16] gmime-cleanup: drop all unused GMimeCryptoContext arguments [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: [PATCH 08/16] gmime-cleanup: drop all unused GMimeCryptoContext arguments [inbox, unread]
    • Daniel Kahn Gillmor—[PATCH 09/16] gmime-cleanup: drop unused gmime #defines and simplify g_mime_init () [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: [PATCH 09/16] gmime-cleanup: drop unused gmime #defines and simplify g_mime_init () [inbox, unread]
    • Daniel Kahn Gillmor—[PATCH 10/16] gmime-cleanup: use GMime 3.0 data types [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
    • Daniel Kahn Gillmor—[PATCH 11/16] gmime-cleanup: use GMime 3.0 function names [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
    • Daniel Kahn Gillmor—[PATCH 12/16] gmime-cleanup: pass NULL arguments explicitly where GMime 3.0 expects it [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
      • David Bremner—Re: [PATCH 12/16] gmime-cleanup: pass NULL arguments explicitly where GMime 3.0 expects it [inbox, unread]
    • Daniel Kahn Gillmor—[PATCH 13/16] gmime-cleanup: pass NULL as default GMimeParserOptions [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Kahn Gillmor—[PATCH 14/16] gmime-cleanup: no longer need to use GMime major version during build [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: [PATCH 14/16] gmime-cleanup: no longer need to use GMime major version during build [inbox, unread]
        • Daniel Kahn Gillmor—Re: [PATCH 14/16] gmime-cleanup: no longer need to use GMime major version during build [inbox, signed, unread]
    • Daniel Kahn Gillmor—[PATCH 15/16] gmime-cleanup: use GMIME_MINVER instead of GMIME3_MINVER [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
    • Daniel Kahn Gillmor—[PATCH 16/16] gmime-cleanup: strip remaining references to GMime 2.6 [inbox, notmuch::obsolete, notmuch::patch, notmuch::trivial, unread]
    • Daniel Kahn Gillmor—[PATCH v2 01/15] build: drop support for gmime-2.6 [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 02/15] gmime-cleanup: drop unused gmime 2.6 content_type from _index_encrypted_mime_part [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 03/15] gmime-cleanup: remove GMime 2.6 variant codeblocks [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 04/15] gmime-cleanup: remove obsolete gpg_path configuration option and crypto contexts [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 05/15] gmime-cleanup: always support session keys [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 06/15] gmime-cleanup: tests should only care about gmime 3 [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 07/15] gmime-cleanup: simplify T355-smime.sh [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 08/15] gmime-cleanup: drop g_mime_2_6_unref [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 09/15] gmime-cleanup: drop all arguments unused in GMime 3 [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 10/15] gmime-cleanup: drop unused gmime #defines and simplify g_mime_init () [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 11/15] gmime-cleanup: use GMime 3.0 data types [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 12/15] gmime-cleanup: use GMime 3.0 function names [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 13/15] gmime-cleanup: pass NULL arguments explicitly where GMime 3.0 expects it [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 14/15] gmime-cleanup: pass NULL as default GMimeParserOptions [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 15/15] gmime-cleanup: no longer need to use GMime major version during build [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—Re: [PATCH v2 01/15] build: drop support for gmime-2.6 [inbox, unread]