Re: [PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag)

Subject: Re: [PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag)

Date: Sun, 01 Apr 2012 15:45:46 -0700

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Sat, Mar 31 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This is version 2 of the exclude= series (version 1 is [1]).
>
> The main changes are the addition of some systematic notmuch-search
> tests for all the exclude options, and I no longer add the
> exclude=flag option to notmuch-show.c (the output was too similar to
> exclude=false to be worth keeping).

Thanks so much for staying on top of this series.  I think this is a
really important new feature and I really appreciate you ferrying it all
the way through to the finish line.

These changes are critical to the functionality as well, as the exclude
stuff currently causes severe performance degradation.  So this is all
very welcome.

I've been using a previous version of this series for weeks now with no
problems at all.  The emacs UI is snappy again.

This new version applies cleanly to the current master, and all tests
pass.  And in my cursory review everything LGTM.

jamie.
part-000.sig (application/pgp-signature)

Thread: