Re: [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create

Subject: Re: [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create

Date: Mon, 18 Feb 2013 21:16:42 -0400

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: David Bremner

David Bremner <david@tethera.net> writes:

> Austin Clements <amdragon@MIT.EDU> writes:
>
>> Previously, there were various opportunities for memory leaks in the
>> error-handling paths of this function.  Use a local talloc context and
>> some reparenting to make eliminate these leaks, while keeping the
>> control flow simple.
>
> pushed all but the python bindings patch.

any comments on that patch, Justus?

For reference, id:1353819427-13182-6-git-send-email-amdragon@mit.edu

d

• Previous message (by thread): Re: [PATCH 5/6] python: Add bindings for notmuch_thread_get_messages

Thread:

• Austin Clements—[PATCH 0/6] API for iterating over all messages in a thread [inbox, unread]
  • Austin Clements—[PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create [inbox, unread]
      • David Bremner—Re: [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create [inbox, unread]
  • Austin Clements—[PATCH 2/6] lib: Separate list of all messages from top-level messages [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 3/6] lib: Eliminate _notmuch_message_list_append [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 4/6] lib: Add an iterator over all messages in a thread [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 5/6] python: Add bindings for notmuch_thread_get_messages [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH 5/6] python: Add bindings for notmuch_thread_get_messages [inbox, unread]
    • David Bremner—Re: [PATCH 5/6] python: Add bindings for notmuch_thread_get_messages [inbox, unread]
  • Austin Clements—[PATCH 6/6] ruby: Add bindings for notmuch_thread_get_messages [inbox, notmuch::patch, notmuch::pushed, unread]
    • Ali Polatel—Re: [PATCH 6/6] ruby: Add bindings for notmuch_thread_get_messages [inbox, notmuch::review, signed, unread]
  • Mark Walters—Re: [PATCH 0/6] API for iterating over all messages in a thread [inbox, notmuch::review, unread]
    • Austin Clements—Re: [PATCH 0/6] API for iterating over all messages in a thread [inbox, unread]
      • Tomi Ollila—Re: [PATCH 0/6] API for iterating over all messages in a thread [inbox, notmuch::review, unread]
        • Austin Clements—Re: [PATCH 0/6] API for iterating over all messages in a thread [inbox, unread]