Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

Date: Tue, 28 Oct 2014 19:15:50 +0100

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner


Jani Nikula <jani@nikula.org> writes:

> You need to actually check the return value. Limit the missing deps
> part to subtests requiring gdb.

For me, on a system without gdb, the current version looks like

T070-insert: Testing "notmuch insert"
 missing prerequisites: gdb(1)
 SKIP   all tests in T070-insert

This seems OK to me?

Of course you're right that moving it forward to only skip the gdb
requiring tests is the right thing to do, and in that setting having a
skipped message for all 10 skipped tests is a bit ugly. OTOHO your
version doesn't give any output at all, which seems not perfect either.


Thread: