Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

Date: Tue, 28 Oct 2014 21:43:12 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Jani Nikula


On Tue, 28 Oct 2014, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> You need to actually check the return value. Limit the missing deps
>> part to subtests requiring gdb.
>
> For me, on a system without gdb, the current version looks like
>
> T070-insert: Testing "notmuch insert"
>  missing prerequisites: gdb(1)
>  SKIP   all tests in T070-insert
>
> This seems OK to me?

More than okay. /me hides.

> Of course you're right that moving it forward to only skip the gdb
> requiring tests is the right thing to do, and in that setting having a
> skipped message for all 10 skipped tests is a bit ugly. OTOHO your
> version doesn't give any output at all, which seems not perfect either.

How does it work if you just move the prereq test forward?

BR,
Jani.

Thread: