Re: pull request

Subject: Re: pull request

Date: Mon, 19 Apr 2010 11:18:52 -0700

To: David Edmondson, notmuch

Cc:

From: Carl Worth


On Mon, 19 Apr 2010 11:07:40 -0700, Carl Worth <cworth@cworth.org> wrote:
> On Mon, 19 Apr 2010 09:27:39 +0100, David Edmondson <dme@dme.org> wrote:
> 
> I've got some misgivings about this one. First, notmuch-search-hook is
> a hook for the user to manipulate, while the hl-line-mode functionality
> is something that should be on by default. That is, if the user happens
> to set the search-hook then the hl-line-mode shouldn't magically
> disappear.

I forgot. The user is expected to use add-hook which avoids this very
problem. So this patch is fine.

-Carl
part-000.sig (application/pgp-signature)

Thread: