On Thu, 26 Jan 2012 14:40:26 +0000, David Edmondson <dme@dme.org> wrote: > In general, I like this. > > - I think that the stash function(s) should take an optional argument > specifying the archive to use. That will make testing simpler and also > allow people to produce preferred bindings more easily. > Agreed. In fact, apparently that last patch [1] of mine made the test suite hang @ emacs:"Stashing in notmuch-show" due to it waiting for `completing-read' to finish... Sorry for that. > - "Message archive: " feels better than "ML Archive: ", but I don't > really care. > Agreed. > - Don't base the patch on the thing that I posted, just on master from > the repository - no need to make David's life harder. Seeing as how it was only a minor improvement to your idea (and further discussion/correction was probably appropriate), I intended for you to squash it into your original patch. Anyways, patch (relative to master) follows... Peace -- Pieter [1] id:"1327583610-30085-1-git-send-email-pieter@praet.org"