Re: [PATCH v6 1/3] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

Subject: Re: [PATCH v6 1/3] emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

Date: Tue, 28 Feb 2012 19:40:04 +0100

To: David Bremner

Cc: Notmuch Mail

From: Pieter Praet


On Sat, 25 Feb 2012 10:40:25 -0400, David Bremner <david@tethera.net> wrote:
> On Sun, 19 Feb 2012 21:50:25 +0100, Pieter Praet <pieter@praet.org> wrote:
> > * emacs/notmuch-show.el
> > 
> >   (notmuch-show-get-message-id):
> >     Add optional arg BARE.  When non-nil, return a Message-Id without
> >     quotes and prefix, thus obviating the need to strip them off again
> >     in various places.
> 
> Pushed all three.
>

Thanks!


Though I couldn't help but notice (it's a curse...) that patch #3
seems to have gained an extra space in its commit message subject:

  Original (id:"1329684627-10708-4-git-send-email-pieter@praet.org"):
    emacs: add `notmuch-show-stash-mlarchive-link{,-and-go}'
                                                  ^
  Pushed (commit 2f86290a):
    emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'
                                                   ^

Don't know whether or not this was accidental, but it's happened
before, with a similar commit message subject:

  Original (id:"1327292557-7701-1-git-send-email-pieter@praet.org"):
    search: rename auto_exclude_tags to {search,}exclude_tags
                                               ^
  Pushed (commit 649a9f5f):
    search: rename auto_exclude_tags to {search, }exclude_tags
                                                ^

Perhaps you're calling uncrustify(1) or something similar
from your '.git/hooks/applypatch-msg' ?

> d


Peace

-- 
Pieter

Thread: