Re: [PATCH v2]: contrib/notmuch-mutt

Subject: Re: [PATCH v2]: contrib/notmuch-mutt

Date: Fri, 30 Mar 2012 18:38:53 -0300

To: Stefano Zacchiroli,


From: David Bremner

On Thu, 29 Mar 2012 15:35:38 +0200, Stefano Zacchiroli <> wrote:
> Here is an updated set of patches, which I consider final for inclusion
> of notmuch-mutt as part of notmuch contrib/.  AFAICT I've implemented
> all changes that have been requested either on this list or in private
> mail to me: renaming, Debian packaging, XDG userdir support, shell
> quoting in all notmuch calls. TTBOMK, no further changes have been
> requested.

I tried out these patches, and they seem to work (to the limit of my
mutt knowledge).  I did notice a minor grammar issue in the DESCRIPTION
of the man page, "capable of populating maildir" should be "a maildir"
or "maildirs". In general for notmuch commit messages we expect a bit
more of the rationale for the commit; in this case a few lines about the
general purpose and (conceiveably) the implementation of notmuch-mutt
would be welcome. See ebd1adc55b for a (probably overkill) example.