Re: [PATCH 2/3] cli: show allow the caller to specify the headers output.

Subject: Re: [PATCH 2/3] cli: show allow the caller to specify the headers output.

Date: Fri, 13 Jul 2012 12:33:49 -0700

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Sat, Jul 07 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> +typedef enum {
> +    NOTMUCH_SHOW_OUTPUT_HDR_DATE = 0x1,
> +    NOTMUCH_SHOW_OUTPUT_HDR_SUBJECT = 0x2,
> +    NOTMUCH_SHOW_OUTPUT_HDR_FROM = 0x4,
> +    NOTMUCH_SHOW_OUTPUT_HDR_TO = 0x8,
> +    NOTMUCH_SHOW_OUTPUT_HDR_CC = 0x10,
> +    NOTMUCH_SHOW_OUTPUT_HDR_REPLY_TO = 0x20,
> +    NOTMUCH_SHOW_OUTPUT_HDR_IN_REPLY_TO = 0x40,
> +    NOTMUCH_SHOW_OUTPUT_HDR_REFERENCES = 0x80,
> +    NOTMUCH_SHOW_OUTPUT_DEFAULT =
> +	    NOTMUCH_SHOW_OUTPUT_HDR_SUBJECT |
> +	    NOTMUCH_SHOW_OUTPUT_HDR_FROM |
> +	    NOTMUCH_SHOW_OUTPUT_HDR_TO |
> +	    NOTMUCH_SHOW_OUTPUT_HDR_CC |
> +	    NOTMUCH_SHOW_OUTPUT_HDR_DATE
> +} notmuch_show_output_t;

Is there a reason we need to limit this to some pre-defined subset of
headers?  Wouldn't it be nice if you could just specify arbitrary
headers?

jamie.
part-000.sig (application/pgp-signature)

Thread: