Re: [PATCH 2/3] cli: show allow the caller to specify the headers output.

Subject: Re: [PATCH 2/3] cli: show allow the caller to specify the headers output.

Date: Fri, 13 Jul 2012 13:37:18 -0700

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Fri, Jul 13 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> I basically agree but it looked like it would be relatively ugly to pass
> around. 
>
> However, perhaps this is all being too general: the caller probably
> cares that all the headers it wants are output and perhaps not too many
> others (eg over ssh or to android etc). Would something more like
> headers=brief or headers=full be enough? And we would still want an
> option allowing the body to be omitted.
>
> What do you think?

I think different people are going to want different headers, and I know
that people want headers that are not included in the default output.
It just seems to me we would be better served with a more general
solution.  Just being able to specify from the headers we are already
outputting doesn't seem like much of an improvement to me.

As for body omission: I still think it would be a nice clean separation
if the contents of body parts were retrieved separately.  If there
really are situations where that constitutes a performance hit, I guess
we'll want the option.  Although I would argue that bodies should be
omitted by default, and the option should include them, rather than
vice-versa.

jamie.
part-000.sig (application/pgp-signature)

Thread: