Re: [PATCH] gzclose_r() and gzclose_w() are not available in older versions of zlib such as the version on Ubuntu LTS 12.04. Changing to gzclose() allows notmuch to work on older versions as well

Subject: Re: [PATCH] gzclose_r() and gzclose_w() are not available in older versions of zlib such as the version on Ubuntu LTS 12.04. Changing to gzclose() allows notmuch to work on older versions as well

Date: Mon, 21 Nov 2016 14:28:09 -0400

To: Ico Doornekamp, notmuch@notmuchmail.org

Cc: Ico Doornekamp

From: David Bremner

Ico Doornekamp <ico@pruts.nl> writes:

> ---
>  configure         |    4 ++--
>  notmuch-dump.c    |    4 ++--
>  notmuch-restore.c |    2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)

Looking at the docs, this looks sensible.

,----
| Same as gzclose(), but gzclose_r() is only for use when reading, and
| gzclose_w() is only for use when writing or appending. The advantage to
| using these instead of gzclose() is that they avoid linking in zlib
| compression or decompression code that is not used when only reading or
| only writing respectively. If gzclose() is used, then both compression
| and decompression code will be included the application when linking to
| a static zlib library.
`----

Probably the commit message could include a paraphrase/quote of the
above.

I take the submitters word for the first version supporting gzclose

Thread: