Re: [PATCH 1/9] lib: Make directory document creation optional for _notmuch_directory_create

Subject: Re: [PATCH 1/9] lib: Make directory document creation optional for _notmuch_directory_create

Date: Wed, 23 May 2012 22:53:25 -0300

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: David Bremner

Austin Clements <amdragon@MIT.EDU> writes:

> Previously this function would create directory documents if they
> didn't exist.  As a result, it could only be used on writable
> databases.  This adds an argument to make creation optional and to
> make this function work on read-only databases.  We use a flag
> argument to avoid a bare boolean and to permit future expansion.

Series pushed, 

d

PS. I marked a couple other of your patches stale in nmbug.

• Previous message (by thread): Re: [PATCH 1/9] lib: Make directory document creation optional for _notmuch_directory_create

Thread:

• Austin Clements—[PATCH 0/9] Fix directory lookup on read-only databases [inbox, unread]
  • Austin Clements—[PATCH 1/9] lib: Make directory document creation optional for _notmuch_directory_create [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH 1/9] lib: Make directory document creation optional for _notmuch_directory_create [inbox, unread]
  • Austin Clements—[PATCH 2/9] lib: Perform the same transformation to _notmuch_database_find_directory_id [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 3/9] lib: Perform the same transformation to _notmuch_database_filename_to_direntry [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 4/9] lib: Make notmuch_database_get_directory return NULL if the directory is not found [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 5/9] new: Remove workaround for detecting newly created directory objects [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 6/9] python: Update Database.get_directory documentation [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 7/9] lib: Make notmuch_database_find_message_by_filename not crash on read-only databases [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 8/9] python: Remove find_message_by_filename workaround [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 9/9] lib: Don't needlessly create directory docs in _notmuch_message_remove_filename [inbox, notmuch::patch, notmuch::pushed, unread]
  • Tomi Ollila—Re: [PATCH 0/9] Fix directory lookup on read-only databases [inbox, notmuch::review, unread]
  • Justus Winter—Re: [PATCH 0/9] Fix directory lookup on read-only databases [inbox, notmuch::review, unread]