Re: [PATCH 0/9] Fix directory lookup on read-only databases

Subject: Re: [PATCH 0/9] Fix directory lookup on read-only databases

Date: Wed, 23 May 2012 12:28:48 +0200

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: Justus Winter

Hi Austin :)

Quoting Austin Clements (2012-05-18 06:13:33)
> This fixes notmuch_database_get_directory and
> notmuch_database_find_message_by_filename so that they don't attempt
> to create missing directory documents.  This makes them work on
> read-only databases (and prevents n_d_f_m_b_f from crashing
> unceremoniously on read-only databases).

Thanks for taking care of this, this patch series looks good.

> If we do a 0.13.1 bug fix release, these patches could go in to
> complement the API changes made in 0.13 to support these fixes.  David
> can make that call.

I'd support this.

Cheers,
Justus

• Previous message (by thread): Re: [PATCH 1/9] lib: Make directory document creation optional for _notmuch_directory_create

Thread:

• Austin Clements—[PATCH 0/9] Fix directory lookup on read-only databases [inbox, unread]
  • Austin Clements—[PATCH 1/9] lib: Make directory document creation optional for _notmuch_directory_create [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH 1/9] lib: Make directory document creation optional for _notmuch_directory_create [inbox, unread]
  • Austin Clements—[PATCH 2/9] lib: Perform the same transformation to _notmuch_database_find_directory_id [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 3/9] lib: Perform the same transformation to _notmuch_database_filename_to_direntry [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 4/9] lib: Make notmuch_database_get_directory return NULL if the directory is not found [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 5/9] new: Remove workaround for detecting newly created directory objects [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 6/9] python: Update Database.get_directory documentation [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 7/9] lib: Make notmuch_database_find_message_by_filename not crash on read-only databases [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 8/9] python: Remove find_message_by_filename workaround [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—[PATCH 9/9] lib: Don't needlessly create directory docs in _notmuch_message_remove_filename [inbox, notmuch::patch, notmuch::pushed, unread]
  • Tomi Ollila—Re: [PATCH 0/9] Fix directory lookup on read-only databases [inbox, notmuch::review, unread]
  • Justus Winter—Re: [PATCH 0/9] Fix directory lookup on read-only databases [inbox, notmuch::review, unread]