On Fri 2015-12-11 09:03:05 -0500, David Bremner wrote: > Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes: > >> This is in large part a duplicate of parts of crypto.c, but that code >> is in the client (outside the library), and we don't want to entangle >> the libgmime API with the libnotmuch API. >> >> I welcome better proposals for how to share this code explicitly >> between the library and the client. > > Maybe I miss something obvious, but util/libutil.a is exactly there for > sharing code between the library and the client. You didn't miss anything obvious -- i did! Thanks for pointing that out, i'll take a look at normalizing these bits for my second draft. > perhaps something like "gmime-extra.c" to go with {talloc,zlib}-extra.c right, sounds good. > I didn't look at the code yet, just the commentary. many thanks for the review, that's why i wrote the commentary :) After a couple nights of sleep, i have a proposal to fix one of the open questions too, which i'll follow up on shortly here. --dkg