Re: [PATCH 2/9] Add a lazily-initialized crypto context to notmuch_database_t

Subject: Re: [PATCH 2/9] Add a lazily-initialized crypto context to notmuch_database_t

Date: Fri, 11 Dec 2015 10:03:05 -0400

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: David Bremner

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> This is in large part a duplicate of parts of crypto.c, but that code
> is in the client (outside the library), and we don't want to entangle
> the libgmime API with the libnotmuch API.
>
> I welcome better proposals for how to share this code explicitly
> between the library and the client.

Maybe I miss something obvious, but util/libutil.a is exactly there for
sharing code between the library and the client.

perhaps something like "gmime-extra.c" to go with {talloc,zlib}-extra.c

I didn't look at the code yet, just the commentary.

d

• Previous message (by thread): Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t

Thread:

• Daniel Kahn Gillmor—allow indexing cleartext of encrypted messages [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 1/9] reorganize indexing of multipart/signed and multipart/encrypted [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 1/9] reorganize indexing of multipart/signed and multipart/encrypted [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 2/9] Add a lazily-initialized crypto context to notmuch_database_t [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 2/9] Add a lazily-initialized crypto context to notmuch_database_t [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 2/9] Add a lazily-initialized crypto context to notmuch_database_t [inbox, unread]
    • Tomi Ollila—Re: [PATCH 2/9] Add a lazily-initialized crypto context to notmuch_database_t [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 3/9] index encrypted parts when the message is flagged appropriately [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 4/9] Add new n_d_add_message_try_decrypt (analogous to to n_d_add_message) [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 5/9] Enable cleartext indexing in python bindings [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 6/9] search for a reasonable gpg implementation [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 6/9] search for a reasonable gpg implementation [inbox, unread]
      • J. Lewis Muir—Re: [PATCH 6/9] search for a reasonable gpg implementation [inbox, unread]
        • Daniel Kahn Gillmor—Re: [PATCH 6/9] search for a reasonable gpg implementation [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 7/9] add a gpg_path value for notmuch_database_t [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t [inbox, unread]
        • Tomi Ollila—Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t [inbox, unread]
        • David Bremner—Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t [inbox, unread]
          • Tomi Ollila—Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t [inbox, unread]
            • Tomi Ollila—Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t [inbox, unread]
              • Daniel Kahn Gillmor—Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t [inbox, unread]
    • J. Lewis Muir—Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 7/9] add a gpg_path value for notmuch_database_t [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 8/9] add --try-decrypt to notmuch insert [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 9/9] add --try-decrypt to notmuch new [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—Re: allow indexing cleartext of encrypted messages [inbox, unread]
    • Tomi Ollila—Re: allow indexing cleartext of encrypted messages [inbox, unread]