Michael J Gruber <git@grubix.eu> writes: > With newer glib, notmuch FTBFS because of C linkage error. This is due > to a misplaced include (inside an extern "C") which was always there > but exposed only recently through this change in glib: > > https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1715 > > Move to the include to the outside of the extern block. Thanks for the patch. I have some questions / comments. 1) What version of glib are we talking about? Is it released yet? 2) The reason this works is that gmime-extra.h has its own extern "C". If respinning the patch, it might be worth commenting on that. 3) I observed that just deleting #include "gmime-extra.h" from notmuch-private.h works fine, presumably because it is included where it is actually needed. In some sense this seems like a nicer solution. What do you think? d _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org