Re: [PATCH] fix build failure with glib 2.67

Subject: Re: [PATCH] fix build failure with glib 2.67

Date: Mon, 15 Feb 2021 22:29:40 +0100

To: David Bremner,


From: Michael J Gruber

David Bremner venit, vidit, dixit 2021-02-15 21:59:17:
> Based on a patch from Michael J Gruber [1].  As of glib 2.67 (more
> specifically [2]), including "gmime-extra.h" inside an extern "C"
> block causes build failures, because glib is using C++ features.
> Observing that "gmime-extra.h" is no longer needed in
> notmuch-private.h, which can simply delete that include, but
> we have to correspondingly move the includes which might include
> it (in particular crypto.h) out of the extern "C" block also.
> This seems less fragile than only moving gmime-extra, and relying on
> preprocessor sentinels to keep the deeper includes from happening.
> Move to the include to the outside of the extern block.
> [1]:
> [2]:
> ---
>  I neglected to change the author when amending. No fair blaming
>  Michael for my potential mistakes

You never know before whether we share the fame or the blame :)

Anyway, the current patch is fully yours.

notmuch mailing list --
To unsubscribe send an email to