Re: [PATCH 1/3] cli: add insert --must-index option

Subject: Re: [PATCH 1/3] cli: add insert --must-index option

Date: Sat, 27 Jul 2013 15:15:10 +1000

To: Mark Walters

Cc: notmuch@notmuchmail.org

From: Peter Wang


On Sun, 21 Jul 2013 09:31:28 +0100, Mark Walters <markwalters1009@gmail.com> wrote:
> 
> Do you have a particular use case where indexing is required but tagging
> is not? For my uses I would prefer failing if either indexing or tagging
> failed. (My use being postponing messages; If they don't get the
> postponed tag they could be hard to find)

You're right.

What about a failure to sync tags to maildir flags?

I now noticed that database modifications aren't flushed until the
notmuch_database_destroy call (right?), which has no return value and
failure of which is silently ignored.  That's acceptable in the default
mode, but with --must-index the failure should be reported (and the
file deleted).

Peter

Thread: