On Fri, 21 Jun 2013 13:59:57 +0300, Tomi Ollila <tomi.ollila@iki.fi> wrote: > On Thu, Jun 20 2013, Mark Walters <markwalters1009@gmail.com> wrote: > > > I think we should decide before 0.16 whether to go with this patch and > > patch 8/8 or for Peter's suggestion at > > id:1368454815-1854-1-git-send-email-novalazy@gmail.com > > > > Now we have an enum for the NOTMUCH_EXCLUDE possibilities (rather than a > > bool) I think it makes sense to implement NOTMUCH_EXCLUDE_FALSE properly > > but I am happy with either choice. > > So, the choice here is to choose between > > id:"1368454815-1854-1-git-send-email-novalazy@gmail.com" > and > id:"87bo8edif8.fsf@qmul.ac.uk" > > (might be hard to catch from this thread -- was easier to take from > http://nmbug.tethera.net/status/ ) > > Both apply cleanly to current master ( d0bd88f ) > > While Peter's version surely looks simpler (and may work, didn't test atm) > the comments Mark presents makes sense (especially the "subtlety" thing ;) > > IMHO Mark's version makes future development "safer" and therefore my > vote (or million of those) goes to id:"87bo8edif8.fsf@qmul.ac.uk" Sure, I don't care. Peter