Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

Subject: Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

Date: Mon, 13 May 2013 23:53:38 +1000

To: David Bremner

Cc: notmuch@notmuchmail.org

From: Peter Wang

On Sun, 12 May 2013 08:20:04 -0300, David Bremner <david@tethera.net> wrote:
> Mark Walters <markwalters1009@gmail.com> writes:
> 
> > -	    notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FALSE);
> > +	    notmuch_query_set_omit_excluded (query, NOTMUCH_EXCLUDE_FLAG);
> 
> Shouldn't the documentation be updated to cover NOTMUCH_EXCLUDE_FLAG?  I
> realize it is not _wrong_ as written, but it is a bit confusing not to
> cover all possible values of the enum.

Actually, please drop patch 7 and patch 8.  It was wrong to combine the
CLI-level EXCLUDE_* constants with the lib-level NOTMUCH_EXCLUDE_* constants.

Peter

• Previous message (by thread): Re: [PATCH v2 8/8] cli: use notmuch_exclude_t in option parser

Thread:

• Mark Walters—[PATCH v2 0/8] search --exclude=all [inbox, unread]
  • Mark Walters—[PATCH v2 1/8] lib: add --exclude=all option [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[PATCH v2 2/8] cli: add --exclude=all option to notmuch-search.c [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[PATCH v2 3/8] test: add tests for search --exclude=all [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[PATCH v2 4/8] man: clarify search --exclude documentation [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 4/8] man: clarify search --exclude documentation [inbox, unread]
  • Mark Walters—[PATCH v2 5/8] man: clarify search --exclude=flag [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[PATCH v2 6/8] man: document search --exclude=all [inbox, notmuch::patch, notmuch::pushed, unread]
  • Mark Walters—[PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t [inbox, unread]
      • Peter Wang—Re: [PATCH v2 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t [inbox, unread]
    • Mark Walters—[PATCH v3 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t [inbox, notmuch::patch, notmuch::pushed, unread]
      • Mark Walters—Re: [PATCH v3 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t [inbox, unread]
        • Tomi Ollila—Re: [PATCH v3 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t [inbox, notmuch::review, unread]
          • Peter Wang—Re: [PATCH v3 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t [inbox, unread]
          • Mark Walters—Re: [PATCH v3 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t [inbox, unread]
      • David Bremner—Re: [PATCH v3 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t [inbox, unread]
  • Mark Walters—[PATCH v2 8/8] cli: use notmuch_exclude_t in option parser [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 8/8] cli: use notmuch_exclude_t in option parser [inbox, unread]
  • Peter Wang—[PATCH v2] cli: clarify correspondence of --exclude to omit_excluded in search [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—Re: [PATCH v2 0/8] search --exclude=all [inbox, unread]