On Sun, Jul 15, 2012 at 10:36:54AM -0600, David Bremner wrote: > email@example.com writes: > > > I hope it's now in the form acceptable for inclusion to contrib. > > Dear Jan; > > Without looking too much at the details I think this is reasonable to > include in contrib, as a set of examples if nothing else. Still, I'm > curious about a few things. Are there actual users (other than the > author)? What would we do about bug reports? Will you follow the list, > or would we explicitely tell people to contact you directly? I might not always have time to read the entirety of the ML, so it would be great if people CC me when posting there. > I guess some of the python experts might want to discuss the coding > style of notmuch-new.py. pylint goes ballistic, for whatever that is > worth. That's mainly because of tabs used for indentation, which used to be considered a viable alternative, but is now considered obsolete. I reformatted the code to conform to pep8 guidelines. > For the shell stuff, I noticed lots of unquoted parameter expansion; > also at some point you make a temporary directory using $$ > directly rather than using e.g. mktemp. Zsh does not word-split parameter expansion by default, this is intentional. The temporary directories are created in xdg cache dir, which should not be susceptible to symlink attacks etc. and the pid actually helps to correlate the directories to processes, eg. when you want to autoclean after searches that got killed for some reason. > What did you have in mind for a license? since there is no linking here, > it does not have to be GPL3+, but some standard Free license is needed I > think; since I'm also maintaining the Debian package, I don't want to > have to remove your stuff before uploading to Debian. You can consider it public domain. I guess I should add wtfpl text to my repo. :-) > d Thanks very much for your rewiev.