Quoth Jani Nikula on May 24 at 11:57 pm: > On Thu, 24 May 2012, Austin Clements <amdragon@MIT.EDU> wrote: > > Before XXX, add_files_recursive could have been called on a symlink to > > a non-directory. Hence, calling it on a non-directory was not an > > error, so a separate function, add_files, existed to fail loudly in > > situations where the path had to be a directory. > > "Before XXX"? Arg. I meant to replace that with a commit ID, but now I don't remember what commit I wanted to reference. > Otherwise, this 3/4 and following 4/4 patch LGTM. I didn't bother > looking at 1/4 and 2/4 again, as you say there were no changes. > > > BR, > Jani.