Re: [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style

Subject: Re: [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style

Date: Wed, 11 Jan 2012 23:00:46 -0500

Cc: notmuch@notmuchmail.org, David Bremner

Quoth David Bremner on Jan 10 at  8:07 am:
> In an ideal situation, running uncrustify on notmuch code would be
> NOP; currently this is not true for all files because 1) the
> configuration is not perfect 2) the coding style of notmuch is not
> completely consistent; in particular the treatment of braces after
> e.g. for (_) is not consistent.

Do you have examples of something this gets wrong besides the funny
indentation of notmuch_show_format_t?

Previous message (by thread): Re: [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style

Thread:

David Bremner—[PATCH] uncrustify.cfg: initial support for notmuch coding style [inbox, notmuch::obsolete, notmuch::patch, unread]
- David Bremner—Re: [PATCH] uncrustify.cfg: initial support for notmuch coding style [inbox, unread]
  - Austin Clements—Re: [PATCH] uncrustify.cfg: initial support for notmuch coding style [inbox, unread]
    - David Bremner—Re: [PATCH] uncrustify.cfg: initial support for notmuch coding style [inbox, unread]
- David Bremner— [inbox, unread]
  - David Bremner—[PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style [inbox, notmuch::patch, notmuch::pushed, unread]
    - Austin Clements—Re: [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style [inbox, unread]
    - Tomi Ollila—Re: [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style [inbox, unread]
    - David Bremner—Re: [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style [inbox, unread]
      - Tomi Ollila—Re: [PATCH 1/2] uncrustify.cfg: initial support for notmuch coding style [inbox, unread]
  - David Bremner—[PATCH 2/2] notmuch-reply.c: uncrustify [inbox, notmuch::obsolete, notmuch::patch, notmuch::wip, unread]
    - Tomi Ollila—Re: [PATCH 2/2] notmuch-reply.c: uncrustify [inbox, unread]
    - Austin Clements—Re: [PATCH 2/2] notmuch-reply.c: uncrustify [inbox, unread]
      - David Bremner—Re: [PATCH 2/2] notmuch-reply.c: uncrustify [inbox, unread]
        Jani Nikula—Re: [PATCH 2/2] notmuch-reply.c: uncrustify [inbox, unread]
        Tomi Ollila—Re: [PATCH 2/2] notmuch-reply.c: uncrustify [inbox, unread]
        Austin Clements—Re: [PATCH 2/2] notmuch-reply.c: uncrustify [inbox, unread]
        David Bremner—Re: [PATCH 2/2] notmuch-reply.c: uncrustify [inbox, unread]
  - Tomi Ollila—where to put uncrustify... (was: Re: ) [inbox, unread]
    - David Bremner—Re: where to put uncrustify... (was: Re: ) [inbox, unread]
    - David Bremner—[PATCH] Start devel directory for developer tools and documentation. [inbox, notmuch::patch, notmuch::pushed, unread]
      - Austin Clements—Re: [PATCH] Start devel directory for developer tools and documentation. [inbox, unread]
      - David Bremner—Re: [PATCH] Start devel directory for developer tools and documentation. [inbox, unread]