Re: [PATCH 2/2] notmuch-reply.c: uncrustify

Subject: Re: [PATCH 2/2] notmuch-reply.c: uncrustify

Date: Wed, 11 Jan 2012 22:57:39 -0500

To: David Bremner

Cc: notmuch@notmuchmail.org, David Bremner

From: Austin Clements


Quoth David Bremner on Jan 10 at  8:07 am:
> From: David Bremner <bremner@debian.org>
> 
> This patch shows the raw result of running uncrustify on notmuch-reply.c.
> The re-indenting of "format_reply" would probably not be desirable.

The good news is that that structure is on its way out.

> @@ -625,6 +612,7 @@ notmuch_reply_command (void *ctx, int argc, char *argv[])
>      notmuch_query_t *query;
>      char *query_string;
>      int opt_index, ret = 0;
> +

This one's a little weird.  Did it get confused by the function
prototype?

>      int (*reply_format_func)(void *ctx, notmuch_config_t *config, notmuch_query_t *query, notmuch_show_params_t *params);
>      notmuch_show_params_t params = { .part = -1 };
>      int format = FORMAT_DEFAULT;

All of the other format fixes look very reasonable to me.  I think you
managed to find one of the least canonical source files in the tree.
Was that intentional?

Thread: