Re: [notmuch] _notmuch_message_create_for_message_id makes extra call to notmuch_database_find_message

Subject: Re: [notmuch] _notmuch_message_create_for_message_id makes extra call to notmuch_database_find_message

Date: Fri, 27 Nov 2009 10:10:58 -0800

To: Carl Worth, notmuch@notmuchmail.org

Cc:

From: Keith Packard


On Fri, 27 Nov 2009 04:46:54 -0800, Carl Worth <cworth@cworth.org> wrote:

> Did the "if" statement immediately afterwards just look like error
> checking? It's not:

Yes, it did (I think my brain may have auto-inserted a '!' there).

Ok, having read the code a bit more carefully, this does look correct.

I have to say that _notmuch_message_create is a bit of a tricky name; as
it doesn't create a message so much as load a message from the database.

-- 
keith.packard@intel.com
part-000.sig (application/pgp-signature)

Thread: