Re: [PATCH] Give a path name to mktemp in Makefile.local

Subject:Re: [PATCH] Give a path name to mktemp in Makefile.local

Date:Sat, 17 Dec 2011 21:55:42 +0200

To:Aaron Ecay ,notmuch@notmuchmail.org

Cc:

From:Tomi Ollila


On Sat, 17 Dec 2011 10:36:25 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> On some systems (incl. OS X 10.6), mktemp expects an argument giving it
> the place to put the new temporary file.
> ---
> 
> On my machine without this patch, make prints a message from mktemp
> about expecting an argument each time it is run.  At some point, make
> got into a situation where it would print this message and exit cleanly,
> but not build any changed files.  A "make clean" was necessary to kick
> it into working again.

All *BSD mktemp's require template argument...

> A disadvantage of this approach is that it drops an empty file into /tmp
> on every make run.  It would be better to only create this file when
> doing "make debian-snapshot", but I am not sure how to do that (cleanly;
> my best idea is to put the build commands into a subshell and export an
> environment variable for the temp file).  Any make/debian experts want
> to take a stab?

Without your patch it does those. Maybe debian-snapshot should
do like:

	cp -f debian/changelog debian/changelog.backup
        ...
        debuild -us -uc
	mv -f debian/changelog.backup debian/changelog

But that is another issue. +1 for your patch.

Tomi

Thread: