On Thu, 24 Nov 2011 16:02:41 -0400, David Bremner <david@tethera.net> wrote: > From: David Bremner <bremner@debian.org> > > When I changed the calling convention to pass in all but the zero-th > argument to subcommands, I missed this one call, resulting in a > segmentation fault. LGTM, is analogous to other 'argc -1, &argv[1]' uses and seems to work on top of notmuch 0.10+21~gae7814b Tomi > --- > notmuch.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/notmuch.c b/notmuch.c > index 77973f8..d44ce9a 100644 > --- a/notmuch.c > +++ b/notmuch.c > @@ -621,7 +621,7 @@ main (int argc, char *argv[]) > return notmuch (local); > > if (STRNCMP_LITERAL (argv[1], "--help") == 0) > - return notmuch_help_command (NULL, 0, NULL); > + return notmuch_help_command (NULL, argc - 1, &argv[1]); > > if (STRNCMP_LITERAL (argv[1], "--version") == 0) { > printf ("notmuch " STRINGIFY(NOTMUCH_VERSION) "\n"); > -- > 1.7.5.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch >