Re: [PATCH 1/3] lib/database: propagate status code from _notmuch_message_delete

Subject: Re: [PATCH 1/3] lib/database: propagate status code from _notmuch_message_delete

Date: Mon, 26 Dec 2022 02:04:28 +0200

To: David Bremner, Thomas Schneider, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Sat, Dec 03 2022, David Bremner wrote:

> _notmuch_message_delete can return (at least)
> NOTMUCH_STATUS_XAPIAN_EXCEPTION, which we should not ignore.

Series LGTM
Tomi


> ---
>  lib/database.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/database.cc b/lib/database.cc
> index c05d70d3..d1e5f1af 100644
> --- a/lib/database.cc
> +++ b/lib/database.cc
> @@ -1456,7 +1456,7 @@ notmuch_database_remove_message (notmuch_database_t *notmuch,
>      if (status == NOTMUCH_STATUS_SUCCESS && message) {
>  	status = _notmuch_message_remove_filename (message, filename);
>  	if (status == NOTMUCH_STATUS_SUCCESS)
> -	    _notmuch_message_delete (message);
> +	    status = _notmuch_message_delete (message);
>  	else if (status == NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID)
>  	    _notmuch_message_sync (message);
>  
> -- 
> 2.35.2
>
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: