Re: [PATCH] notmuch-emacs-mua: avoid extra separators at the end of the line

Subject: Re: [PATCH] notmuch-emacs-mua: avoid extra separators at the end of the line

Date: Thu, 30 Nov 2023 19:12:42 +0200

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Thu, Nov 30 2023, Jani Nikula wrote:

> Currently the --to/--cc/--bcc options add "user@example.com, " to the
> message headers, with the the unnecessary ", " separator after the
> last address, regardless of how many addresses are being added.
>
> This used to be fine, but with recent emacs mm, trying to send the
> email with the trailing commas leads to prompt:
>
>   Email address  looks invalid; send anyway? (y or n)
>
> Fix this by only adding the commas between addresses, avoiding the
> trailing commas.

LGTM.

Tomi


> ---
>  emacs/notmuch-emacs-mua | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch-emacs-mua b/emacs/notmuch-emacs-mua
> index a521497784ec..254e6407cece 100755
> --- a/emacs/notmuch-emacs-mua
> +++ b/emacs/notmuch-emacs-mua
> @@ -41,6 +41,9 @@ CREATE_FRAME=
>  ELISP=
>  MAILTO=
>  HELLO=
> +TO_SEP=
> +CC_SEP=
> +BCC_SEP=
>  
>  # Short options compatible with mutt(1).
>  while getopts :s:c:b:i:h opt; do
> @@ -86,13 +89,16 @@ while getopts :s:c:b:i:h opt; do
>  	    ELISP="${ELISP} (message-goto-subject) (insert \"${OPTARG}\")"
>  	    ;;
>  	--to)
> -	    ELISP="${ELISP} (message-goto-to) (insert \"${OPTARG}, \")"
> +	    ELISP="${ELISP} (message-goto-to) (insert \"${TO_SEP}${OPTARG}\")"
> +	    TO_SEP=", "
>  	    ;;
>  	--cc|c)
> -	    ELISP="${ELISP} (message-goto-cc) (insert \"${OPTARG}, \")"
> +	    ELISP="${ELISP} (message-goto-cc) (insert \"${CC_SEP}${OPTARG}\")"
> +	    CC_SEP=", "
>  	    ;;
>  	--bcc|b)
> -	    ELISP="${ELISP} (message-goto-bcc) (insert \"${OPTARG}, \")"
> +	    ELISP="${ELISP} (message-goto-bcc) (insert \"${BCC_SEP}${OPTARG}\")"
> +	    BCC_SEP=", "
>  	    ;;
>  	--body|i)
>  	    ELISP="${ELISP} (message-goto-body) (insert-file \"${OPTARG}\")"
> -- 
> 2.39.2
>
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: