On Mon, Dec 11 2023, David Bremner wrote:

> Sandra Snan <sandra.snan@idiomdrottning.org> writes:
>
>
>> +(defvar in-notmuch-mua-reply-functions nil
>> +  "Functions to run after `notmuch-reply' was called successfully
>> +without erroring. The functions get the message-id as a string
>> +argument.")
>> +
>
> Overall this looks reasonable to me, but I'm not sure about the
> name. Since emacs doesn't have any namespace facility, I think that any
> globals we define should probably start with 'notmuch-'

I'd also mention that name starting with in-* -- my first thought would
have been inconsistency, but that "namespace" naming is (even) more
important.

another thing what should be the parameters passed, and why. this change
adds (just) message-id but no reasoning (nor documentation) there...

other than these notes, the change looks reasonable to me, too :D

>
> d

Tomi
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org