Re: [PATCH] test/emacs: add workaround for Emacs 30 pp changes

Subject: Re: [PATCH] test/emacs: add workaround for Emacs 30 pp changes

Date: Tue, 25 Feb 2025 16:19:11 +0200

To: David Bremner, Xiyue Deng, Liam Hupfer, notmuch@notmuchmail.org

Cc: 1098852@bugs.debian.org

From: Tomi Ollila


On Tue, Feb 25 2025, David Bremner wrote:

> This relies on the fact that setting pp-default-function has no effect
> for Emacs <30.

I think this close to a release (and maybe for a while later) this is LGTM.

Tomi

> ---
>  test/test-lib.el | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/test/test-lib.el b/test/test-lib.el
> index 4cfb8ef1..bf1fab66 100644
> --- a/test/test-lib.el
> +++ b/test/test-lib.el
> @@ -33,6 +33,9 @@
>  
>  (require 'cl-lib)
>  
> +;; Use old pretty print algorithm, so tests don't break with Emacs 30
> +(setq-default pp-default-function 'pp-28)
> +
>  ;; Ensure that the dynamic variables that are defined by this library
>  ;; are defined by the time that we let-bind them.  This is needed
>  ;; because starting with Emacs 27 undeclared variables in evaluated
> -- 
> 2.47.2
>
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: