Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch

Subject: Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch

Date: Thu, 13 Sep 2012 13:10:53 +0200

To: Jani Nikula, notmuch@notmuchmail.org, David Bremner

Cc:

From: Michal Nazarewicz

On Wed, Sep 12 2012, Jani Nikula <jani@nikula.org> wrote:
> Add a date/time parser to notmuch, to be used for adding date range
> query support for notmuch lib later on. Add the parser to a directory
> of its own to make it independent of the rest of the notmuch code
> base.
>
> Signed-off-by: Jani Nikula <jani@nikula.org>

Have you consider doing the same in bison?  I consider the code totally
unreadable and unmaintainable.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--

• Previous message (by thread): Re: [PATCH] test: Improve tests for the date/time parser module

Thread:

• Jani Nikula—[PATCH v3 0/9] notmuch search date:since..until query support [inbox, unread]
  • Jani Nikula—[PATCH v3 1/9] build: drop the -Wswitch-enum warning [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Michal Nazarewicz—Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch [inbox, signed, unread]
      • Jani Nikula—Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch [inbox, unread]
        • Michal Nazarewicz—Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch [inbox, signed, unread]
          • Jani Nikula—Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch [inbox, unread]
      • Tomi Ollila—Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch [inbox, unread]
    • Michal Sojka—Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch [inbox, unread]
      • Jani Nikula—Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch [inbox, unread]
        • Michal Sojka—Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch [inbox, unread]
  • Jani Nikula—[PATCH v3 3/9] test: add new test tool parse-time for date/time parser [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH v3 4/9] test: add smoke tests for the date/time parser module [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Michal Sojka—[PATCH] test: Improve tests for the date/time parser module [inbox, unread]
      • Jani Nikula—Re: [PATCH] test: Improve tests for the date/time parser module [inbox, unread]
        • Michal Sojka—Re: [PATCH] test: Improve tests for the date/time parser module [inbox, unread]
  • Jani Nikula—[PATCH v3 5/9] build: build parse-time-string as part of the notmuch lib and static cli [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH v3 6/9] lib: add date range query support [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Michal Nazarewicz—Re: [PATCH v3 6/9] lib: add date range query support [inbox, signed, unread]
      • Tomi Ollila—Re: [PATCH v3 6/9] lib: add date range query support [inbox, unread]
        • Jani Nikula—Re: [PATCH v3 6/9] lib: add date range query support [inbox, unread]
          • Michal Nazarewicz—Re: [PATCH v3 6/9] lib: add date range query support [inbox, signed, unread]
      • David Bremner—Re: [PATCH v3 6/9] lib: add date range query support [inbox, unread]
        • Michal Nazarewicz—Re: [PATCH v3 6/9] lib: add date range query support [inbox, signed, unread]
          • Tomi Ollila—Re: [PATCH v3 6/9] lib: add date range query support [inbox, unread]
          • David Bremner—Re: [PATCH v3 6/9] lib: add date range query support [inbox, unread]
      • Michal Sojka—Re: [PATCH v3 6/9] lib: add date range query support [inbox, unread]
  • Jani Nikula—[PATCH v3 7/9] test: add tests for date:since..until range queries [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH v3 8/9] man: document the date:since..until range queries [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH v3 9/9] NEWS: date range search support [inbox, notmuch::obsolete, notmuch::patch, unread]