Re: [PATCH] devel: make printmimestructure py3 compatible

Subject: Re: [PATCH] devel: make printmimestructure py3 compatible

Date: Tue, 12 Jun 2018 12:47:58 +0200

To: Tomi Ollila, Daniel Kahn Gillmor, Notmuch Mail


From: Thomas Schneider

Tomi Ollila <> writes:

> On Mon, Jun 11 2018, Daniel Kahn Gillmor wrote:
>> Make printmimestructure work in python3 as well as python2.
>> PEP 394 suggests that python scripts that work with both python2 and
>> python3 should have a #!/usr/bin/python command line, so do that too.
> I did not see PEP 394 suggesting to change 
> -#!/usr/bin/env python
> +#!/usr/bin/python
> just that 'python' should be able to run both python2 and python3 code.
> after the above change the code will not run on (those stupid) systems
> that install python to e.g. /usr/local/bin/.

For example all BSD systems, where the package manager installs to
/usr/local (and I do not think this is stupid).

> While I am not against this change, the commit message is misleading.

For the above reason, I am against changing the shebang at all.

notmuch mailing list