Re: [PATCH] Install notmuch-git during make install

Subject: Re: [PATCH] Install notmuch-git during make install

Date: Fri, 23 Aug 2024 17:46:30 +0200

To: Michael J Gruber

Cc: notmuch@notmuchmail.org

From: Martin Jambor


Hi,

On Thu, Aug 22 2024, Michael J Gruber wrote:
> Am Do., 22. Aug. 2024 um 14:37 Uhr schrieb Martin Jambor <mjambor@suse.cz>:
>>
>> Hi,
>>
>> I have noticed that notmuch-git was not being copied to an appropriate
>> destination during make install.  This patch adds that.
>>
>> ---
>>  Makefile.local | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile.local b/Makefile.local
>> index 7699c208..34e8b882 100644
>> --- a/Makefile.local
>> +++ b/Makefile.local
>> @@ -278,6 +278,7 @@ notmuch-shared: $(notmuch_client_modules) lib/$(LINKER_NAME)
>>  install: all install-man install-info
>>         mkdir -p "$(DESTDIR)$(prefix)/bin/"
>>         install notmuch-shared "$(DESTDIR)$(prefix)/bin/notmuch"
>> +       install notmuch-git "$(DESTDIR)$(prefix)/bin/notmuch-git"
>
> notmuch-git(1) mentions nmbug, so we'd want to install that as well, don't we?

I don't know.   I have never even contemplated using it but it looks
much more like an internal tool to me.

However, after a discussion about notmuch-git on the IRC I learned that
there may be plans to change it, so perhaps even my patch should be
postponed until after that.  I really don't know.

Martin

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: