Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

Subject: Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.

Date: Mon, 16 Jan 2012 15:51:30 -0500

To: David Edmondson, Pieter Praet, notmuch@notmuchmail.org

Cc:

From: Aaron Ecay


On Mon, 16 Jan 2012 11:22:27 +0000, David Edmondson <dme@dme.org> wrote:
> On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet <pieter@praet.org> wrote:
> > Alas, those text properties actually *were* effective (and I liked them :)
> 
> Well, not in emacs 24. My reading of the source was that overlays were
> intended to stomp on text properties, but that could have been wrong.
> 
> Do they look correct when you add/remove tags?

The tags look nice and yellow-green for me too on a trunk build of emacs
(which is one flavor of emacs 24).  Adding and removing tags works as
expected – the tags dis/appear and are the right color.

I haven’t reloaded the notmuch *.el files since this change landed, but
I agree with Pieter that the overlays were nice.

-- 
Aaron Ecay

Thread: