Re: [PATCH] tests: fix test_json_nodes() in out-of-tree builds

Subject: Re: [PATCH] tests: fix test_json_nodes() in out-of-tree builds

Date: Sun, 24 May 2020 20:59:29 +0300

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: Tomi Ollila

On Thu, May 21 2020, Daniel Kahn Gillmor wrote:

> In out-of-tree builds, $TEST_DIRECTORY doesn't contain
> json_check_nodes.py.  This caused 27 tests to fail in such an
> environment.

are you shure the run_emacs.sh change in 

id:"20200423212643.864-1-tomi.ollila@iki.fi"

is not needed ? =D

Tomi

>
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> ---
>  test/test-lib.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 58972339..792b1cb9 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -556,7 +556,7 @@ test_json_nodes () {
>  
>  	if ! test_skip "$test_subtest_name"
>  	then
> -	    output=$(PYTHONIOENCODING=utf-8 $NOTMUCH_PYTHON "$TEST_DIRECTORY"/json_check_nodes.py "$@")
> +	    output=$(PYTHONIOENCODING=utf-8 $NOTMUCH_PYTHON "$NOTMUCH_SRCDIR"/test/json_check_nodes.py "$@")
>  		if [ "$?" = 0 ]
>  		then
>  			test_ok_
> -- 
> 2.26.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: