Re: [PATCH] contrib: pick: tidy up pick-format-field

Subject: Re: [PATCH] contrib: pick: tidy up pick-format-field

Date: Mon, 16 Sep 2013 23:15:29 +0300

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> Previously this function used a temporary variable to store the return
> value but we can just use the return value of the cond statement
> directly.
>
> The only tiny subtlety is that in one case (subject) we need to
> slightly reorder the logic to make sure the formatted-field is the
> last thing computed.
> ---

> This follows Tomi's suggestion in id:m2ob7vg24n.fsf@guru.guru-group.fi

LGTM

Tomi

> and simplifies the code here slightly. This patch applies on top of the
> series at id:1378092488-32050-1-git-send-email-markwalters1009@gmail.com
>
> (It also includes one small whitespace fix-up for the face for the tags)
>
>
>  contrib/notmuch-pick/notmuch-pick.el |   49 ++++++++++++++-------------------
>  1 files changed, 21 insertions(+), 28 deletions(-)
>

Thread: