On Mon, May 20 2019, Leo Vivier wrote: > Hello, > > With the patch now in master, the documentation for Emacs (‘Tips and > Tricks for using Notmuch with Emacs’) needs to be updated: > https://notmuchmail.org/emacstips/#index5h2 > > ‘notmuch-search-interactive-region’ is mentioned in the second block of > Elisp. > > Also, could we mark the old function as obsolete? Some of my commands > broke after pulling the changes, and that’s what led me to the doc in > the first place. > > I’ve attached a quick patch for marking the old command as obsolete. I > don't think the `emacstips' doc is in the repo, so I couldn't fix it. It is wiki -- look around the web page to see how to update. > > Best, > > -- > Leo Vivier > From 5481c2fe61d9e776d15166bc46f8dfc6221bf975 Mon Sep 17 00:00:00 2001 > From: Leo Vivier <leo.vivier+org@gmail.com> > Date: Mon, 20 May 2019 14:21:13 +0200 > Subject: [PATCH] emacs: make old function obsolete > > `notmuch-search-interactive-region' was moved to notmuch-lib.el in > f3cba19f882471a396a6b6175a709ccd1f6f34a0 and renamed to > `notmuch-interactive-region' without making the old function > obsolete, thereby breaking user-commands which made use of it. > > This patch marks the function as obsolete and makes it an alias for s/patch/commit/ -- it is no longer patch when applied! it may be possible that db could amend this... Tomi > the new function. > --- > emacs/notmuch-lib.el | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el > index 7fc342a5..96a1da90 100644 > --- a/emacs/notmuch-lib.el > +++ b/emacs/notmuch-lib.el > @@ -1017,6 +1017,11 @@ region if the region is active, or both `point' otherwise." > (list (region-beginning) (region-end)) > (list (point) (point)))) > > +(define-obsolete-function-alias > + 'notmuch-search-interactive-region > + 'notmuch-interactive-region > + "notmuch 0.28.1") > + > (provide 'notmuch-lib) > > ;; Local Variables: > -- > 2.21.0 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch