On Tuesday, 2019-12-24 at 10:54:46 -05, Daniel Kahn Gillmor wrote: > On Tue 2019-12-24 10:59:09 +0000, David Edmondson wrote: >> Patch looks good, though I would quite like there to be a comment in the >> code. Something simple like: >> >> /* text/rfc822-headers was replaced by text/plain as the MIME type for >> “Legacy Display” parts - we allow either. */ > > I have no objection to having this comment in the code (though i think > i'd replace U+201C LEFT DOUBLE QUOTATION MARK and U+201D RIGHT DOUBLE > QUOTATION MARK with U+0022 QUOTATION MARK. i don't think we have any > non-ASCII text in our C source at the moment, and this doesn't seem like > the right place to introduce it. Agreed. > Since the code will be read in the future, not the past, i think the > right comment might be: > > /* Early implementations that generated "Legacy Display" parts used > Content-Type: text/rfc822-headers, but text/plain is more widely > rendered, so it is now the standard choice. We accept either as a > Legacy Display part. */ Looks good to me, thank you. > Bremner, if you are considering a merge, and want to inject this comment > yourself, that's fine with me. let me know if you want me to send > another revision instead. > > --dkg dme. -- And the sign said: long haired freaky people need not apply. _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch