On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> This uses the recently added global keymap for pick entry. Adding this
> showed a couple of historical anomalies: first that we don't need to
> quote the keymap in define-key, and secondly that the
> notmuch-pick-from-hello function is no longer needed.
>
> Thus we remove the superfluous quotes and we remove the unneeded
> function.
>
> All tests pass and all key bindings still seem to work.

This series LGTM. I don't fully understand this (fset 'kmap kmap)
business but everywhere I looked (define-key uses the non-symbol-reference
to the keymap (were there fsets or not))

>
> Best wishes
>
> Mark

Tomi


>
>
> Mark Walters (3):
>   contrib: pick: remove some superfluous quotes
>   contrib: pick: use the new notmuch-common-keymap for pick entry
>   contrib: pick: remove unused notmuch-pick-from-hello
>
>  contrib/notmuch-pick/notmuch-pick.el |   21 ++++-----------------
>  1 files changed, 4 insertions(+), 17 deletions(-)
>
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch