Re: [PATCH] cli: cast timeval fields to long for format

Subject: Re: [PATCH] cli: cast timeval fields to long for format

Date: Tue, 28 Oct 2014 09:15:28 +0000

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Edmondson


On Tue, Oct 28 2014, Jani Nikula wrote:
> This hides platform differences between struct timeval field types.

Good for me. Tested on Debian Testing and OS X 10.10 (which previously
emitted a compiler warning).

> ---
>  notmuch-insert.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/notmuch-insert.c b/notmuch-insert.c
> index 7074077..0d2d810 100644
> --- a/notmuch-insert.c
> +++ b/notmuch-insert.c
> @@ -197,7 +197,7 @@ tempfilename (const void *ctx)
>      gettimeofday (&tv, NULL);
>  
>      filename = talloc_asprintf (ctx, "%ld.M%ldP%d.%s",
> -				tv.tv_sec, tv.tv_usec, pid, hostname);
> +				(long) tv.tv_sec, (long) tv.tv_usec, pid, hostname);
>      if (! filename)
>  	fprintf (stderr, "Error: %s\n", strerror (ENOMEM));
>  
> -- 
> 1.7.2.5
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: