Re: [PATCH 2/2] show: Simplify new text formatter code

Subject: Re: [PATCH 2/2] show: Simplify new text formatter code

Date: Mon, 30 Jan 2012 16:59:54 +0200

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Thu, 26 Jan 2012 01:55:26 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> This makes the text formatter take advantage of the new code
> structure.  The previously duplicated header logic is now unified,
> several things that we used to compute repeatedly across different
> callbacks are now computed once, and the code is simpler overall and
> 32% shorter.
> 
> Unifying the header logic causes this to format some dates slightly
> differently, so the two affected test cases are updated.
> ---

Looks good, works fine.


Tomi

• Previous message (by thread): Re: [PATCH 0/2] Rewrite text show format

Thread:

• Austin Clements—[PATCH 0/2] Rewrite text show format [inbox, unread]
  • Austin Clements—[PATCH 1/2] show: Convert text format to the new self-recursive style [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Dmitry Kurochkin—Re: [PATCH 1/2] show: Convert text format to the new self-recursive style [inbox, notmuch::review, unread]
      • Austin Clements—Re: [PATCH 1/2] show: Convert text format to the new self-recursive style [inbox, unread]
  • Austin Clements—[PATCH 2/2] show: Simplify new text formatter code [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Tomi Ollila—Re: [PATCH 2/2] show: Simplify new text formatter code [inbox, notmuch::review, unread]
    • Dmitry Kurochkin—Re: [PATCH 2/2] show: Simplify new text formatter code [inbox, notmuch::review, unread]
      • Austin Clements—Re: [PATCH 2/2] show: Simplify new text formatter code [inbox, unread]
  • Austin Clements—[PATCH v2 0/2] Rewrite text show format [inbox, unread]
    • Austin Clements—[PATCH v2 1/2] show: Convert text format to the new self-recursive style [inbox, notmuch::patch, notmuch::pushed, unread]
    • Austin Clements—[PATCH v2 2/2] show: Simplify new text formatter code [inbox, notmuch::patch, notmuch::pushed, unread]
    • Dmitry Kurochkin—Re: [PATCH v2 0/2] Rewrite text show format [inbox, unread]
    • David Bremner—Re: [PATCH v2 0/2] Rewrite text show format [inbox, unread]
  • Adam Wolfe Gordon—Re: [PATCH 0/2] Rewrite text show format [inbox, unread]