Re: [PATCH] cli: bail out and propagate tagging errors in notmuch tag

Subject: Re: [PATCH] cli: bail out and propagate tagging errors in notmuch tag

Date: Thu, 10 Jan 2013 06:26:54 +0200

To: David Bremner, Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Thu, Jan 10 2013, David Bremner <david@tethera.net> wrote:

> Jani Nikula <jani@nikula.org> writes:
>> +	if (ret)
>> +	    break;
>
> I amended this to (ret != NOTMUCH_STATUS_SUCCESS) 
>
> There are a few different families of status codes flying around here,
> and I liked the extra documentation.

That sure is a good point, should follow-up patch do this:

-    int ret = 0;
+    int ret = NOTMUCH_STATUS_SUCCESS;

?

> d

Tomi

• Previous message (by thread): Re: [PATCH] notmuch-tag: initialize with enum instead of 0.

Thread:

• Jani Nikula—[PATCH] cli: bail out and propagate tagging errors in notmuch tag [inbox, notmuch::patch, notmuch::pushed, unread]
  • Tomi Ollila—Re: [PATCH] cli: bail out and propagate tagging errors in notmuch tag [inbox, notmuch::review, unread]
  • David Bremner—Re: [PATCH] cli: bail out and propagate tagging errors in notmuch tag [inbox, unread]
    • Tomi Ollila—Re: [PATCH] cli: bail out and propagate tagging errors in notmuch tag [inbox, unread]
      • David Bremner—Re: [PATCH] cli: bail out and propagate tagging errors in notmuch tag [inbox, unread]
      • david@tethera.net—[PATCH] notmuch-tag: initialize with enum instead of 0. [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
        • Tomi Ollila—Re: [PATCH] notmuch-tag: initialize with enum instead of 0. [inbox, unread]
        • David Bremner—Re: [PATCH] notmuch-tag: initialize with enum instead of 0. [inbox, unread]