Re: [PATCH] build: fix out-of-tree builds

Subject: Re: [PATCH] build: fix out-of-tree builds

Date: Thu, 16 May 2013 15:01:10 +0300

To: David Bremner, Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Thu, May 16 2013, David Bremner <david@tethera.net> wrote:

> Jani Nikula <jani@nikula.org> writes:
>
>> On Wed, 15 May 2013, David Bremner <david@tethera.net> wrote:
>>> Jani Nikula <jani@nikula.org> writes:
>>>>  # List all subdirectories here. Each contains its own Makefile.local
>>>> -subdirs := compat completion emacs lib man parse-time-string
>>>> -subdirs += performance-test util test
>>>> +subdirs = compat completion emacs lib man parse-time-string performance-test util test
>>>
>>> Is this a functional change or a cosmetic one?
>>
>> Functional. All of it seems to be required for out-of-tree builds (*) to
>> work. I'm afraid I've forgotten exactly why both := and += make it fail
>> (I wrote the patch a few months ago).
>>
>
> Still I guess it deserves a comment so we don't break it again?

The following options could be tested (some day in (distant?) future):

subdirs = compat completion emacs lib man parse-time-string
subdirs += performance-test util test

or 

SUBDIRS := compat completion emacs lib man parse-time-string
SUBDIRS += performance-test util test
subdirs = $(SUBDIRS)

but as Jani has already tested his version works just adding that
comment David asked is the least labor-intensive thing to do --
and therefore IMHO the best thing to do for this case
(for sure I'm not going to spend more time on this now :D).

> d

Tomi

Thread: