On Tue, May 21 2013, Ali Polatel <polatel@gmail.com> wrote: > 2013/05/21 Tomi Ollila <tomi.ollila@iki.fi>: >>On Mon, May 20 2013, Felipe Contreras <felipe.contreras@gmail.com> wrote: >> >>> It has never existed in Ruby (maybe JRuby). Fortunately the symbols are >>> loaded lazily, so nobody would notice unless they try >>> 'query::count_messages'. >>> >>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> >> >>This patch could be pushed on it's own, but someone (like Ali) could >>comment on the change as searches on both UINT2FIX() & UINT2NUM() >>provides (IMH) insatisfactory results... > > LGTM. > > My bad, there's no such thing as UINT2FIX(). > Yet, what's wrong with UINT2NUM()? Nothing wrong -- although it seems obvious UINT2NUM() is the right thing to do I was not qualified to say so... > > The description looks like: > "...take an unsigned int and convert it to a FIXNUM object if it will fit; > otherwise, convert to a Bignum object..." ... as I did not find this description when browsing the search results (now this was in the first search result -- sometimes one just doesn't get the right search terms in place)... > > Besides ruby-1.8 has it and that's the oldest version I was willing to > support. (If you have some free time, please confirm this because I may > not be remembering correctly.) Cannot confirm for sure -- I found references to UINT2NUM() and ruby 1.8.6... .. anyway UINT2FIX() doesn't work and UINT2NUM() works with very high probablility I'd say lets get this pushed. "Hey, it compiles! Ship It !" > >>Tomi > > -alip Tomi