Re: [PATCH 0/2] Move pick to use prefix-arg rather than Escape

Subject: Re: [PATCH 0/2] Move pick to use prefix-arg rather than Escape

Date: Tue, 01 Oct 2013 11:50:22 +0300

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Mon, Sep 23 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> To try and minimise the impact of pick on the code base some
> keybindings which would naturally use a prefix argument were done as a
> separate keybinding with "M-". (The reason is that a prefix argument
> would have meant modifying the original function whereas the M- could
> be bound to a new function in pick)
>
> The first patch is actually all inside pick anyway so can be
> changed. The second patch removes a different occurence of the M-
> keybinding temporarily: we can add back the prefix-arg version once
> pick is in mainline.
>
> I also have some patches to add the prefix-argument (going to pick) to
> hello buttons and other search entry points.  (I think this is a good
> reason to make the change from M- to prefix-arg as it is much easier
> to link the prefix-arg into button actions).

LGTM.

Tomi

>
> Best wishes
>
> Mark
>
> Mark Walters (2):
>   contrib: pick: move M-RET to prefix-arg RET
>   contrib: pick: remove temporary keybinding
>
>  contrib/notmuch-pick/notmuch-pick.el |   52 +++++++++++++---------------------
>  1 files changed, 20 insertions(+), 32 deletions(-)
>
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: