Re: [PATCH 0/2] emacs: show: use interactive instead of current-prefix-arg

Subject: Re: [PATCH 0/2] emacs: show: use interactive instead of current-prefix-arg

Date: Thu, 10 Oct 2013 13:21:37 +0300

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Wed, Oct 09 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> This is a tidied up version of the patch at
> id:1380729013-3942-1-git-send-email-markwalters1009@gmail.com
> (incorporating suggestions from Tomi in
> id:m2siwjhapc.fsf@guru.guru-group.fi)
>
> This helps fix a problem in pick but there was reasonable agreement on
> irc that show should not be looking at current-prefix-arg directly.
>
> One test needs to be changed to the new behaviour.

LGTM. Having elide-toggle &optional looks like a very good idea!

Tomi

>
> Best wishes
>
> Mark
>
>
> Mark Walters (2):
>   emacs: show: use interactive instead of current-prefix-arg
>   test: emacs-show: fix use of prefix-arg
>
>  emacs/notmuch-show.el |   12 +++++++-----
>  emacs/notmuch.el      |    5 +++--
>  test/emacs-show       |    3 +--
>  3 files changed, 11 insertions(+), 9 deletions(-)
>
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: