Re: [PATCH] Fix author-scan.sh on BSD systems.

Subject: Re: [PATCH] Fix author-scan.sh on BSD systems.

Date: Tue, 03 Aug 2021 23:35:23 +0300

To: Matt Armstrong, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Sat, Feb 13 2021, Matt Armstrong wrote:

> BSD xargs does not have the -d option. Here we use tr to convert
> newlines to NUL characters, then pass -0 to xargs (which BSD does
> support).
>
> I looked at passing -z to 'git ls-files', but I did not find a BSD
> grep option to turn on NUL deliminted line processing.
> ---
>  devel/author-scan.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/devel/author-scan.sh b/devel/author-scan.sh
> index 2d9c4af8..23854f39 100644
> --- a/devel/author-scan.sh
> +++ b/devel/author-scan.sh
> @@ -5,7 +5,7 @@ AUTHOR_EXCLUDE='uncrustify'
>  # based on the FSF guideline, for want of a better idea.
>  THRESHOLD=15
>  
> -git ls-files | grep -v -e "$FILE_EXCLUDE" | xargs -n 1 -d \\n \
> +git ls-files | grep -v -e "$FILE_EXCLUDE" | tr '\n' '\0' | xargs -0 -n 1 \

LGTM. David will know if this works for the task this is needed :D

Tomi

>                                                    git blame -w --line-porcelain -- | \
>      sed -n "/$AUTHOR_EXCLUDE/d; s/^[aA][uU][tT][hH][Oo][rR] //p" | \
>      sort -fd | uniq -ic | awk "\$1 >= $THRESHOLD" | sort -nr
> -- 
> 2.30.0
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: